[
https://issues.apache.org/jira/browse/ZOOKEEPER-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951701#comment-13951701
]
Hadoop QA commented on ZOOKEEPER-297:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12637588/build_version3.patch
against trunk revision 1582572.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 4 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1996//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1996//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1996//console
This message is automatically generated.
> centralize version numbering in the source/build
> ------------------------------------------------
>
> Key: ZOOKEEPER-297
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-297
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.5.0
> Reporter: Patrick Hunt
> Assignee: Diego de Oliveira
> Priority: Minor
> Labels: patch
> Fix For: 3.5.0
>
> Attachments: build_version.patch, build_version.patch,
> build_version2.patch, build_version3.patch
>
>
> There are now three locations in the source repository that store the version
> number of the code:
> 1) build.xml
> 2) configure.ac
> 3) zookeeper_version.h
> these all have to be managed when releasing/branching/etc... would be better
> if there were just one place - at the very least the configure.ac should be
> used to generate the version for zookeeper_version.h.
> Can we do a better job (ie less) at this?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
