----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20071/#review39812 -----------------------------------------------------------
./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java <https://reviews.apache.org/r/20071/#comment72445> trivial nit: spaces around (deathWatcher != null) ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java <https://reviews.apache.org/r/20071/#comment72446> trivial nit: drop the comment and just keep the catch block in the same line, i.e.: ``` } catch (InterruptedException e) {} ``` ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java <https://reviews.apache.org/r/20071/#comment72447> was this meant to be getDeathWatchInterval()? ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java <https://reviews.apache.org/r/20071/#comment72448> ditto wrt swallowed exceptions. ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java <https://reviews.apache.org/r/20071/#comment72449> I think we can do more here.. i.e.: actually find out what thread is not running and print that out? We can either go over all threads and check or we can have isRunning throw something like CriticalThreadNotRunning() or such? - Raul Gutierrez Segales On April 7, 2014, 2:01 a.m., Rakesh R wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20071/ > ----------------------------------------------------------- > > (Updated April 7, 2014, 2:01 a.m.) > > > Review request for zookeeper, michim, Raul Gutierrez Segales, and Camille > Fournier. > > > Bugs: ZOOKEEPER-1907 > https://issues.apache.org/jira/browse/ZOOKEEPER-1907 > > > Repository: zookeeper > > > Description > ------- > > Improve the thread handling mechanism by detecting if any of the critical > thread dies. > Here the idea is to periodically checking the status of all the critical > threads in ZK server using DeathWatcherThread. > > > Diffs > ----- > > ./src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java > 1585370 > ./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java > 1585370 > ./src/java/main/org/apache/zookeeper/server/RequestProcessor.java 1585370 > ./src/java/main/org/apache/zookeeper/server/ServerConfig.java 1585370 > ./src/java/main/org/apache/zookeeper/server/SessionTracker.java 1585370 > ./src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 1585370 > ./src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java > 1585370 > > ./src/java/main/org/apache/zookeeper/server/UnimplementedRequestProcessor.java > 1585370 > ./src/java/main/org/apache/zookeeper/server/ZooKeeperCriticalThread.java > 1585370 > ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 1585370 > ./src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java > 1585370 > ./src/java/main/org/apache/zookeeper/server/quorum/AckRequestProcessor.java > 1585370 > ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java > 1585370 > > ./src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java > 1585370 > ./src/java/main/org/apache/zookeeper/server/quorum/Leader.java 1585370 > > ./src/java/main/org/apache/zookeeper/server/quorum/LeaderRequestProcessor.java > 1585370 > > ./src/java/main/org/apache/zookeeper/server/quorum/LeaderSessionTracker.java > 1585370 > > ./src/java/main/org/apache/zookeeper/server/quorum/LearnerSessionTracker.java > 1585370 > > ./src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java > 1585370 > > ./src/java/main/org/apache/zookeeper/server/quorum/ProposalRequestProcessor.java > 1585370 > ./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 1585370 > ./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java > 1585370 > ./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java > 1585370 > > ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java > 1585370 > > ./src/java/main/org/apache/zookeeper/server/quorum/SendAckRequestProcessor.java > 1585370 > ./src/java/test/org/apache/zookeeper/server/PrepRequestProcessorTest.java > 1585370 > ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java > 1585370 > > Diff: https://reviews.apache.org/r/20071/diff/ > > > Testing > ------- > > yet to be inlcuded > > > Thanks, > > Rakesh R > >
