[ https://issues.apache.org/jira/browse/ZOOKEEPER-1371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13965124#comment-13965124 ]
Roy Sindre Norangshol commented on ZOOKEEPER-1371: -------------------------------------------------- [~michim] Can probably create an issue with docs that is related to this one yes, if your thinking about -> http://zookeeper.apache.org/doc/r3.3.3/zookeeperAdmin.html#Debug+Log+Cleanup+%28log4j%29 etc. What generates the docs/? I assume there is a tool or something that generates all the html/pdfs. Would be best to ensure docs are updated with the release. Regarding the jmx log4j bean stuff, it should really be distributed as it's own artifact and then move the log4j specific implementation to this artifact together with the test. Because it doesn't really belong at all in the main project. Then users can contribute to other jmx logging artifacts for logback etc as well. So I highly suggest to move it to its own artifact (jmx/log4j test we currently have), or at least move it to contrib and out of the main project. > Remove dependency on log4j in the source code. > ---------------------------------------------- > > Key: ZOOKEEPER-1371 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1371 > Project: ZooKeeper > Issue Type: Bug > Affects Versions: 3.4.0, 3.4.1, 3.4.2, 3.4.3 > Reporter: Mahadev konar > Assignee: César Álvarez Núñez > Labels: patch > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1371.patch, ZOOKEEPER-1371.patch, > ZOOKEEPER-1371.patch, ZOOKEEPER-1371.patch > > > ZOOKEEPER-850 added slf4j to ZK. We still depend on log4j in our codebase. We > should remove the dependency on log4j so that we can make logging pluggable. -- This message was sent by Atlassian JIRA (v6.2#6252)