[
https://issues.apache.org/jira/browse/ZOOKEEPER-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968790#comment-13968790
]
Bruno Freudensprung commented on ZOOKEEPER-1835:
------------------------------------------------
Ok, here are the results.
The short version:
- on Linux, tests results are the same with and without the patch (so I can't
reproduce Flavio's test failure),
- on Windows, tests results are better with the patch (even though results are
very strange : timeouts, 3 times longer to run on Windows than on Linux despite
a far better CPU - maybe an effect of the SSD?).
The long version:
Test plateforms:
- Ubuntu 13.04 x64 / Oracle Java 1.7 x64 / Celeron G530 / SSD
- Windows 7 x64 / Oracle Java 1.7 x64 / Core i7 860 / HDD
Test suite runs in 45 minutes on Linux, and in 165 minutes on Windows.
Linux trunk-only (failures and errors) and Linux trunk+patch are the same:
Running org.apache.zookeeper.server.quorum.StandaloneDisabledTest
Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 107,875 sec
Running org.apache.zookeeper.test.StaticHostProviderTest
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0 sec
Windows trunk+patch (failures and errors):
Test org.apache.zookeeper.server.ZxidRolloverTest FAILED (timeout)
Test org.apache.zookeeper.server.quorum.ReconfigRecoveryTest FAILED
Test org.apache.zookeeper.test.FollowerResyncConcurrencyTest FAILED
(timeout)
Test org.apache.zookeeper.test.LeaderSessionTrackerTest FAILED (timeout)
Test org.apache.zookeeper.test.QuorumTest FAILED (timeout)
Test org.apache.zookeeper.test.ReadOnlyModeTest FAILED (timeout)
Test org.apache.zookeeper.test.ReconfigTest FAILED (timeout)
Test org.apache.zookeeper.test.StaticHostProviderTest FAILED (timeout)
Windows trunk-only (failures and errors) has the same than above, plus these:
Test org.apache.zookeeper.ZooKeeperTest FAILED
Test org.apache.zookeeper.ZooKeeperTestableTest FAILED
Test org.apache.zookeeper.server.CRCTest FAILED
Test org.apache.zookeeper.server.InvalidSnapCountTest FAILED
Test org.apache.zookeeper.server.util.DynamicConfigBCTest FAILED
Test org.apache.zookeeper.test.AsyncHammerTest FAILED (crashed)
I'll try another run on Windows with the SSD to see if results are reproducible.
> dynamic configuration file renaming fails on Windows
> ----------------------------------------------------
>
> Key: ZOOKEEPER-1835
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1835
> Project: ZooKeeper
> Issue Type: Bug
> Components: quorum
> Affects Versions: 3.5.0
> Environment: Windows 7 64-bit, Oracle Java 1.6.0_32-b05
> Reporter: Bruno Freudensprung
> Assignee: Bruno Freudensprung
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1835.patch, ZOOKEEPER-1835.patch,
> ZOOKEEPER-1835.patch, ZOOKEEPER-1835.patch
>
>
> On Windows, reconfig fails to rename the tmp dynamic config file to the real
> dynamic config filename.
> Javadoc of java.io.File.renameTo says the behavior is highly plateform
> dependent, so I guess this should not be a big surprise.
> The problem occurs in
> src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java that
> could be modified like this:
> + curFile.delete();
> if (!tmpFile.renameTo(curFile)) {
> + configFile.delete();
> if (!tmpFile.renameTo(configFile)) {
> As suggested by Alex in https://issues.apache.org/jira/browse/ZOOKEEPER-1691
> (btw there is more information about my test scenario over there) it is a bit
> "scary" to delete the current configuration file.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
