[
https://issues.apache.org/jira/browse/ZOOKEEPER-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13998984#comment-13998984
]
Hadoop QA commented on ZOOKEEPER-1836:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12644670/ZOOKEEPER-1836.patch
against trunk revision 1594755.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 patch. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2089//console
This message is automatically generated.
> addrvec_next() fails to set next parameter if addrvec_hasnext() returns false
> -----------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1836
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1836
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Reporter: Dutch T. Meyer
> Assignee: Dutch T. Meyer
> Priority: Trivial
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1836.patch, ZOOKEEPER-1836.patch
>
>
> There is a relatively innocuous but useless pointer assignment in
> addrvec_next():
> 195 void addrvec_next(addrvec_t *avec, struct sockaddr_storage *next)
> ....
> 203 if (!addrvec_hasnext(avec))
> 204 {
> 205 next = NULL;
> 206 return;
> That assignment on (205) has no point, as next is a local variable lost upon
> function return. Likely this should be a memset to zero out the actual
> parameter.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
