[
https://issues.apache.org/jira/browse/ZOOKEEPER-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14014952#comment-14014952
]
Rakesh R commented on ZOOKEEPER-1659:
-------------------------------------
bq.new tests verifyRemoteBean(String remoteBean) seems to be verifying that the
bean is not registered. Please change the function name to reflect that.
I've replaced using JMX.ensureNone(rBeanName). This is already available and
serves the purpose.
bq.I don't fully understand the remote and local bean naming convention. Can
you please explain ?
It is actually to represents the object name pattern identifying the MBean to
be retrieved, in our case it is RemotePeerMXBean and LocalPeerMXBean beans.
Test case first tries to get the given MBean, then gets the value of a specific
attribute of that MBean and does the assertion. I've modified the variable
names 'remoteBean and localBean' to 'remotePeerBean and localPeerBean'. Also
I've tried modifying the method names to get more clarity, is that fine ?
> Add JMX support for dynamic reconfiguration
> -------------------------------------------
>
> Key: ZOOKEEPER-1659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1659
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.5.0
> Reporter: Alexander Shraer
> Assignee: Rakesh R
> Priority: Blocker
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1659.patch, ZOOKEEPER-1659.patch,
> ZOOKEEPER-1659.patch, ZOOKEEPER-1659.patch, ZOOKEEPER-1659.patch
>
>
> We need to update JMX during reconfigurations. Currently, reconfiguration
> changes are not reflected in JConsole.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
