[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stevo Slavic updated ZOOKEEPER-1350:
------------------------------------

    Attachment: ZOOKEEPER-1350-trunk.diff

Attaching [^ZOOKEEPER-1350-trunk.diff].
Compared to [^ZOOKEEPER-1350.diff], this one can be applied to trunk branch + 
it contains tiny improvement as suggested by Raúl Gutiérrez Segalés in [his 
comment on pull 
request|https://github.com/apache/zookeeper/pull/13#commitcomment-6663089].

> Please make JMX registration optional in LearnerZooKeeperServer
> ---------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1350
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1350
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server
>    Affects Versions: 3.4.0
>            Reporter: Jordan Zimmerman
>            Assignee: Jordan Zimmerman
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1350-trunk.diff, ZOOKEEPER-1350.diff, 
> jmx_optional.diff, patch.txt
>
>
> LearnerZooKeeperServer has no option to disable JMX registrations. Curator 
> has a test ZK server cluster. Due to the intricacies of JMX, the 
> registrations cannot be easily undone. In order for the Curator Test cluster 
> to be re-usable in a testing session, JavaAssist ugliness was necessary to 
> make LearnerZooKeeperServer.registerJMX() and 
> LearnerZooKeeperServer.unregisterJMX() NOPs. 
> I suggest a simple System property.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to