[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14034440#comment-14034440
 ] 

Raul Gutierrez Segales commented on ZOOKEEPER-827:
--------------------------------------------------

Thanks for the review [~fpj]. So the last version of the patch has:

{noformat}
 #ifdef _WINDOWS
-static int zookeeper_send(SOCKET s, const void* buf, int len)
+typedef SOCKET socket_t;
+typedef int sendsize_t;
+#define SEND_FLAGS  0
 #else
-static ssize_t zookeeper_send(int s, const void* buf, size_t len)
+typedef int socket_t;
+typedef ssize_t sendsize_t;
+#define SEND_FLAGS  MSG_NOSIGNAL
 #endif
{noformat}

why would  #ifdef _WINDOWS not be the path inside Win? Or is that macro not 
available on all Win platforms?


> enable r/o mode in C client library
> -----------------------------------
>
>                 Key: ZOOKEEPER-827
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-827
>             Project: ZooKeeper
>          Issue Type: Sub-task
>            Reporter: Sergey Doroshenko
>            Assignee: Raul Gutierrez Segales
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-827.patch, ZOOKEEPER-827.patch, 
> ZOOKEEPER-827.patch, ZOOKEEPER-827.patch, ZOOKEEPER-827.patch, 
> ZOOKEEPER-827.patch, ZOOKEEPER-827.patch
>
>
> Implement read-only mode functionality (in accordance with 
> http://wiki.apache.org/hadoop/ZooKeeper/GSoCReadOnlyMode) in C client library



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to