[
https://issues.apache.org/jira/browse/ZOOKEEPER-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037578#comment-14037578
]
Hadoop QA commented on ZOOKEEPER-1943:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12651457/ZOOKEEPER-1943-branch34.patch
against trunk revision 1601516.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 patch. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2139//console
This message is automatically generated.
> "src/contrib/zooinspector/NOTICE.txt" isn't complying to ".gitattributes" in
> branch-3.4
> ---------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1943
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1943
> Project: ZooKeeper
> Issue Type: Bug
> Components: contrib
> Affects Versions: 3.4.6
> Reporter: Hongchao Deng
> Assignee: Hongchao Deng
> Fix For: 3.4.7
>
> Attachments: ZOOKEEPER-1943-branch34.patch
>
>
> Using the git repo and checkout "branch-3.4", the
> "src/contrib/zooinspector/NOTICE.txt" file always shows up for changes but
> cannot be checkout or reset.
> This is caused by ".gitattributes" line "text=auto" where git automatically
> sets the line ending stuff.
> To solve this, I am gonna commit the git auto change and submit it as a patch
> for "branch-3.4".
--
This message was sent by Atlassian JIRA
(v6.2#6252)
