----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23085/#review46844 -----------------------------------------------------------
src/java/main/org/apache/zookeeper/server/WatchManager.java <https://reviews.apache.org/r/23085/#comment82413> Thanks Raul for taking this ahead. I prefer printing 'DataWatches' and 'ChildWatches' separately in output, this would be self explanatory. But if we have a better way with clear documentation also fine for me. - Rakesh R On June 26, 2014, 7:19 p.m., Raul Gutierrez Segales wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23085/ > ----------------------------------------------------------- > > (Updated June 26, 2014, 7:19 p.m.) > > > Review request for zookeeper, fpj, michim, Patrick Hunt, and Rakesh R. > > > Bugs: ZOOKEEPER-1274 > https://issues.apache.org/jira/browse/ZOOKEEPER-1274 > > > Repository: zookeeper-git > > > Description > ------- > > commit 99c6fd1adc1c4cc8227afc5510e277963f867a41 > Author: Raul Gutierrez S <[email protected]> > Date: Wed Jun 25 20:11:22 2014 -0700 > > ZOOKEEPER-1274: Support child watches to be displayed with 4 letter > zookeeper commands (i.e. wchs, wchp and wchc) > > Signed-off-by: Raul Gutierrez S <[email protected]> > > :100644 100644 0b03c94... 7401f7a... M CHANGES.txt > :100644 100644 f652e43... 0315e8d... M > src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml > :100644 100644 f2a4f86... 17f723e... M > src/java/main/org/apache/zookeeper/server/DataTree.java > :100644 100644 39bf82e... 9038d54... M > src/java/main/org/apache/zookeeper/server/WatchManager.java > > > Diffs > ----- > > CHANGES.txt 0b03c94 > src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml f652e43 > src/java/main/org/apache/zookeeper/server/DataTree.java f2a4f86 > src/java/main/org/apache/zookeeper/server/WatchManager.java 39bf82e > > Diff: https://reviews.apache.org/r/23085/diff/ > > > Testing > ------- > > It works like this: > > ``` > $ echo wchs | nc localhost 2181 > Data watches > 1 connections watching 1 paths > Total watches:1 > Children watches > 1 connections watching 1 paths > Total watches:1 > > $ echo wchp | nc localhost 2181 > /something > 0x404164a6e40000 > /something/ > 0x404164a6e40000 > > $ echo wchc | nc localhost 2181 > 0x404164a6e40000 > /something > 0x404164a6e40000 > /something/ > ``` > > > Thanks, > > Raul Gutierrez Segales > >
