----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23081/#review46948 -----------------------------------------------------------
Ship it! Just a few minor comments, otherwise it looks good. src/c/include/zookeeper.h <https://reviews.apache.org/r/23081/#comment82517> As I understand it, this code indicates that a write operation was tried when connected to a read-only server. If this is right, then the code should be something like ZISREADONLY or simply ZREADONLY. src/c/src/addrvec.c <https://reviews.apache.org/r/23081/#comment82518> Just a style comment, I'd rather use curly braces even if there is just a single line of code for the if. src/c/src/zookeeper.c <https://reviews.apache.org/r/23081/#comment82519> Same here, I'd rather use curly braces even if not necessary. - fpj On June 27, 2014, 6:45 p.m., Raul Gutierrez Segales wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23081/ > ----------------------------------------------------------- > > (Updated June 27, 2014, 6:45 p.m.) > > > Review request for zookeeper, fpj, michim, Patrick Hunt, Rakesh R, and Thawan > Kooburat. > > > Bugs: ZOOKEEPER-827 > https://issues.apache.org/jira/browse/ZOOKEEPER-827 > > > Repository: zookeeper-git > > > Description > ------- > > commit e93806d0a6dfd8b372b0557fb5dfbbaca6ae8178 > Author: Raul Gutierrez S <r...@itevenworks.net> > Date: Sun Jun 8 21:43:48 2014 -0700 > > ZOOKEEPER-827. enable r/o mode in C client library > > Signed-off-by: Raul Gutierrez S <r...@itevenworks.net> > > :100644 100644 6130c4d... a7b2621... M src/c/Makefile.am > :100644 100644 fe25015... 045ef9a... M src/c/README > :100644 100644 d5a3876... 18a203d... M src/c/include/zookeeper.h > :100644 100644 4134044... c6887f5... M src/c/src/addrvec.c > :100644 100644 5345ebc... 3897095... M src/c/src/addrvec.h > :100644 100644 aab214d... a9d11e1... M src/c/src/cli.c > :100644 100644 0d3ae19... 0c513e8... M src/c/src/load_gen.c > :100644 100644 21dc70c... eec505c... M src/c/src/zk_adaptor.h > :100644 100644 795875e... 3cc9393... M src/c/src/zookeeper.c > :100644 100644 41d5179... c6536dc... M src/c/tests/TestClientRetry.cc > :000000 100644 0000000... 37ab147... A > src/c/tests/TestReadOnlyClient.cc > :000000 100644 0000000... 035f26d... A src/c/tests/WatchUtil.h > :100644 100644 f97c943... 263f3ce... M src/c/tests/ZKMocks.cc > :100644 100644 fbcfc4f... 2717ded... M src/c/tests/ZKMocks.h > :000000 100644 0000000... aa2dd8c... A src/c/tests/quorum.cfg > :100755 100755 0af80f8... 33ab152... M src/c/tests/zkServer.sh > > > Diffs > ----- > > src/c/Makefile.am 6130c4d > src/c/README fe25015 > src/c/include/zookeeper.h d5a3876 > src/c/src/addrvec.h 5345ebc > src/c/src/addrvec.c 4134044 > src/c/src/cli.c aab214d > src/c/src/load_gen.c 0d3ae19 > src/c/src/zk_adaptor.h 21dc70c > src/c/src/zookeeper.c 795875e > src/c/tests/TestClientRetry.cc 41d5179 > src/c/tests/TestReadOnlyClient.cc PRE-CREATION > src/c/tests/WatchUtil.h PRE-CREATION > src/c/tests/ZKMocks.h fbcfc4f > src/c/tests/ZKMocks.cc f97c943 > src/c/tests/quorum.cfg PRE-CREATION > src/c/tests/zkServer.sh 0af80f8 > > Diff: https://reviews.apache.org/r/23081/diff/ > > > Testing > ------- > > all tests pass, *should* compile on Windows. > > > Thanks, > > Raul Gutierrez Segales > >