[
https://issues.apache.org/jira/browse/ZOOKEEPER-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14049215#comment-14049215
]
Raul Gutierrez Segales commented on ZOOKEEPER-1933:
---------------------------------------------------
bq. I'm not sure what you're trying to say here. In the case of an error, it
clears interest. Are you saying this is not sufficient, broken or something
else I'm missing?
I wasn't sure if zookeeper_process() dealt correctly with the error condition.
bq. Which tests are you talking about? the test case? I have added that one, so
it is possible I have misunderstood something.
I meant you exercised the code, but as you mentioned and now that I actually
looked in more detail zookeeper_process() *does* the check:
{noformat}
int zookeeper_process(zhandle_t *zh, int events)
{
buffer_list_t *bptr;
int rc;
if (zh==NULL)
return ZBADARGUMENTS;
if (is_unrecoverable(zh))
return ZINVALIDSTATE;
{noformat}
So it generally lgtm, +1. An updated patch with the missing header file would
be good for a last read though. Thanks [~oho] and [~fpj].
> Windows release build of zk client cannot connect to zk server
> --------------------------------------------------------------
>
> Key: ZOOKEEPER-1933
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1933
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.4.6
> Reporter: Norris Lee
> Assignee: Orion Hodson
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1933-2.patch, ZOOKEEPER-1933-3.patch,
> ZOOKEEPER-1933.patch, ZOOKEEPER-1933.patch, ZOOKEEPER-1933.patch
>
>
> When building zookeeper in Visual Studio in debug mode, the client can
> connect to the server without error. When building in release mode, I get a
> continuous error message:
> {code}
> 2014-06-02 11:25:20,070:7144(0xc84):ZOO_INFO@zookeeper_init_internal@1008:
> Initiating client connection, host=192.168.39.43:5181 sessionTimeout=30000
> watcher=10049C90 sessionId=0 sessionPasswd=<null> context=001FC0F0 flags=0
> 2014-06-02 11:25:20,072:7144(0xc84):ZOO_DEBUG@start_threads@221: starting
> threads...
> 2014-06-02 11:25:20,072:7144(0x1ea0):ZOO_DEBUG@do_completion@460: started
> completion thread
> 2014-06-02 11:25:20,072:7144(0x1e08):ZOO_DEBUG@do_io@403: started IO thread
> 2014-06-02
> 11:25:20,072:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1148: [OLD]
> count=0 capacity=0 next=0 hasnext=0
> 2014-06-02
> 11:25:20,072:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1151: [NEW]
> count=1 capacity=16 next=0 hasnext=1
> 2014-06-02
> 11:25:20,072:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1160: Using
> next from NEW=192.168.39.43:5181
> 2014-06-02 11:25:20,072:7144(0x1e08):ZOO_DEBUG@zookeeper_interest@1992: [zk]
> connect()
> 2014-06-02 11:25:20,158:7144(0x1e08):ZOO_ERROR@handle_socket_error_msg@1847:
> Socket [192.168.39.43:5181] zk retcode=-4, errno=10035(Unknown error): failed
> to send a handshake packet: Unknown error
> 2014-06-02 11:25:20,158:7144(0x1e08):ZOO_DEBUG@handle_error@1595: Previous
> connection=[192.168.39.43:5181] delay=0
> 2014-06-02
> 11:25:20,158:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1148: [OLD]
> count=0 capacity=0 next=0 hasnext=0
> 2014-06-02
> 11:25:20,158:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1151: [NEW]
> count=1 capacity=16 next=0 hasnext=1
> 2014-06-02
> 11:25:20,158:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1160: Using
> next from NEW=192.168.39.43:5181
> 2014-06-02 11:25:20,158:7144(0x1e08):ZOO_DEBUG@zookeeper_interest@1992: [zk]
> connect()
> 2014-06-02 11:25:20,159:7144(0x1e08):ZOO_ERROR@handle_socket_error_msg@1847:
> Socket [192.168.39.43:5181] zk retcode=-4, errno=10035(Unknown error): failed
> to send a handshake packet: Unknown error
> 2014-06-02 11:25:20,159:7144(0x1e08):ZOO_DEBUG@handle_error@1595: Previous
> connection=[192.168.39.43:5181] delay=0
> 2014-06-02
> 11:25:20,159:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1148: [OLD]
> count=0 capacity=0 next=0 hasnext=0
> 2014-06-02
> 11:25:20,159:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1151: [NEW]
> count=1 capacity=16 next=0 hasnext=1
> 2014-06-02
> 11:25:20,159:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1160: Using
> next from NEW=192.168.39.43:5181
> 2014-06-02 11:25:20,159:7144(0x1e08):ZOO_DEBUG@zookeeper_interest@1992: [zk]
> connect()
> 2014-06-02 11:25:20,159:7144(0x1e08):ZOO_ERROR@handle_socket_error_msg@1847:
> Socket [192.168.39.43:5181] zk retcode=-4, errno=10035(Unknown error): failed
> to send a handshake packet: Unknown error
> 2014-06-02 11:25:20,159:7144(0x1e08):ZOO_DEBUG@handle_error@1595: Previous
> connection=[192.168.39.43:5181] delay=0
> 2014-06-02
> 11:25:20,159:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1148: [OLD]
> count=0 capacity=0 next=0 hasnext=0
> 2014-06-02
> 11:25:20,159:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1151: [NEW]
> count=1 capacity=16 next=0 hasnext=1
> 2014-06-02
> 11:25:20,159:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1160: Using
> next from NEW=192.168.39.43:5181
> 2014-06-02 11:25:20,159:7144(0x1e08):ZOO_DEBUG@zookeeper_interest@1992: [zk]
> connect()
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
