----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20635/#review48045 -----------------------------------------------------------
http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ExpiryQueue.java <https://reviews.apache.org/r/20635/#comment84297> Now that the times are all nanoTime-based, this Date may not come out correctly as a wall-clock time. Maybe something to note somewhere. http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/systest/org/apache/zookeeper/test/system/GenerateLoad.java <https://reviews.apache.org/r/20635/#comment84302> Since this is just a report printed out, maybe wall-clock time is OK. (Unless this is parsed somewhere and used for checking elapsed time.) - Bill Havanki On April 23, 2014, 6:07 p.m., michim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20635/ > ----------------------------------------------------------- > > (Updated April 23, 2014, 6:07 p.m.) > > > Review request for zookeeper. > > > Repository: zookeeper > > > Description > ------- > > Updated the patch so that it applies cleanly, and addressed Asad's comment: > > https://issues.apache.org/jira/browse/ZOOKEEPER-1366?focusedCommentId=13759315&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13759315 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/ClientCnxn.java > 1589522 > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/ClientCnxnSocket.java > 1589522 > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/Shell.java > 1589522 > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/ZKUtil.java > 1589522 > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/common/Time.java > PRE-CREATION > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ExpiryQueue.java > 1589522 > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java > 1589522 > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/Request.java > 1589522 > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ServerStats.java > 1589522 > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java > 1589522 > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java > 1589522 > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/AuthFastLeaderElection.java > 1589522 > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java > 1589522 > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/Follower.java > 1589522 > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/Leader.java > 1589522 > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/systest/org/apache/zookeeper/test/system/GenerateLoad.java > 1589522 > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/systest/org/apache/zookeeper/test/system/InstanceManager.java > 1589522 > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/systest/org/apache/zookeeper/test/system/SimpleSysTest.java > 1589522 > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/common/TimeTest.java > PRE-CREATION > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java > 1589522 > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ClientBase.java > 1589522 > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ClientHammerTest.java > 1589522 > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/test/CnxManagerTest.java > 1589522 > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java > 1589522 > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ReadOnlyModeTest.java > 1589522 > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java > 1589522 > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/test/TestHammer.java > 1589522 > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ZooKeeperTestClient.java > 1589522 > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/recipes/queue/src/c/tests/Util.cc > 1589522 > > Diff: https://reviews.apache.org/r/20635/diff/ > > > Testing > ------- > > > Thanks, > > michim > >
