[
https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14066285#comment-14066285
]
Hudson commented on ZOOKEEPER-1683:
-----------------------------------
SUCCESS: Integrated in ZooKeeper-trunk #2376 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2376/])
ZOOKEEPER-1683. ZooKeeper client NPE when updating server list on disconnected
client (shralex via michim) (michim:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1611474)
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/src/c/tests/TestReconfig.cc
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/ClientCnxnSocketNIO.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
*
/zookeeper/trunk/src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java
> ZooKeeper client NPE when updating server list on disconnected client
> ---------------------------------------------------------------------
>
> Key: ZOOKEEPER-1683
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1683
> Project: ZooKeeper
> Issue Type: Bug
> Components: java client
> Affects Versions: 3.5.0
> Reporter: Shevek
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1683-ver1.patch, ZOOKEEPER-1683-ver2.patch,
> ZOOKEEPER-1683-ver2.patch, ZOOKEEPER-1683-ver5.patch,
> ZOOKEEPER-1683-ver5.patch, ZOOKEEPER-1683-ver6.patch,
> ZOOKEEPER-1683-ver7.patch, ZOOKEEPER-1683.patch
>
>
> 2013-04-04 22:16:15,872 ERROR [pool-4-thread-1]
> com.netflix.curator.ConnectionState.getZooKeeper (ConnectionState.java:84) -
> Background exception caught
> java.lang.NullPointerException
> at
> org.apache.zookeeper.client.StaticHostProvider.updateServerList(StaticHostProvider.java:161)
> ~[zookeeper-3.5.0.jar:3.5.0--1]
> at
> org.apache.zookeeper.ZooKeeper.updateServerList(ZooKeeper.java:183)
> ~[zookeeper-3.5.0.jar:3.5.0--1]
> at
> com.netflix.curator.HandleHolder$1$1.setConnectionString(HandleHolder.java:121)
> ~[curator-client-1.3.5-SNAPSHOT.jar:?]
> The duff code is this:
> ClientCnxnSocket clientCnxnSocket = cnxn.sendThread.getClientCnxnSocket();
> InetSocketAddress currentHost = (InetSocketAddress)
> clientCnxnSocket.getRemoteSocketAddress();
> boolean reconfigMode = hostProvider.updateServerList(serverAddresses,
> currentHost);
> Now, currentHost might be null, if we're not yet connected. But
> StaticHostProvider.updateServerList indirects on it unconditionally.
> This would be caught by findbugs.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
