-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23678/
-----------------------------------------------------------

Review request for zookeeper.


Bugs: ZOOKEEPER-776
    https://issues.apache.org/jira/browse/ZOOKEEPER-776


Repository: zookeeper-git


Description
-------

Addition of a check that the client session timeout is at least at a minimum. 
The work here is based on the original patches from Gregory Haskins.

* In Java, the minimum is controlled by the zookeeper.minTimeout system 
property, with default of 100.
* In C, the minimum is fixed at 100.

Room for improvement (suggestions and assistance most welcome):

* There is no new unit test for the C client.
* The minimum in the C client is not configurable.
* The minimum enforcement is not yet documented.


Diffs
-----

  src/c/src/zookeeper.c 782ac52 
  src/java/main/org/apache/zookeeper/ClientCnxn.java b4ece07 
  src/java/test/org/apache/zookeeper/ClientCnxnTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/23678/diff/


Testing
-------

Compiles, new unit test passes.


Thanks,

Bill Havanki

Reply via email to