Hongchao Deng created ZOOKEEPER-1972:
----------------------------------------
Summary: Use AtomicLong for logical clock
Key: ZOOKEEPER-1972
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1972
Project: ZooKeeper
Issue Type: Sub-task
Reporter: Hongchao Deng
Assignee: Hongchao Deng
Fix For: 3.5.0
The findbugs complains about incrementing a volatile variable in
[AuthFastLeaderElection|https://github.com/apache/zookeeper/blob/087abf83684167ae56864fe4c3be0079fa653266/src/java/main/org/apache/zookeeper/server/quorum/AuthFastLeaderElection.java#L737]:
{code}
volatile long logicalclock; /* Election instance */
...
logicalclock++;
{code}
Actually this is a bug. It should use AtomicLong here instead of volatile.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
