[
https://issues.apache.org/jira/browse/ZOOKEEPER-1789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14067635#comment-14067635
]
Hadoop QA commented on ZOOKEEPER-1789:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12656740/ZOOKEEPER-1789.patch
against trunk revision 1611846.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 87 new Findbugs (version
2.0.3) warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2203//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2203//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2203//console
This message is automatically generated.
> 3.4.x observer causes NPE on 3.5.0 (trunk) participants
> -------------------------------------------------------
>
> Key: ZOOKEEPER-1789
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1789
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.5.0
> Reporter: Raul Gutierrez Segales
> Assignee: Alexander Shraer
> Priority: Critical
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1789.patch, ZOOKEEPER-1789.patch
>
>
> (assigning to Alex because this was introduced by ZOOKEEPER-107, but will
> upload a patch as well.)
> I have a 5 participants cluster running what will be 3.5.0 (i.e.: trunk as of
> today) and an observer running 3.4 (trunk from 3.4 branch). When the observer
> tries to establish a connection to the participants I get:
> {noformat}
> Thread Thread[10.40.78.121:3888,5,main] died java.lang.NullPointerException
> at
> org.apache.zookeeper.server.quorum.QuorumCnxManager.receiveConnection(QuorumCnxManager.java:240)
> at
> org.apache.zookeeper.server.quorum.QuorumCnxManager$Listener.run(QuorumCnxManager.java:552)
> {noformat}
> Looking at QuorumCnxManager.java:240:
> {noformat}
> if (protocolVersion >= 0) { // this is a server id and not a
> protocol version
> sid = protocolVersion;
> electionAddr = self.getVotingView().get(sid).electionAddr;
> } else {
> {noformat}
> and self.getVotingView().get(sid) will be null for Observers. So this block
> should cover that case.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
