[
https://issues.apache.org/jira/browse/ZOOKEEPER-1975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14067802#comment-14067802
]
Hadoop QA commented on ZOOKEEPER-1975:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12656772/ZOOKEEPER-1975.patch.2
against trunk revision 1612015.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 10 new Findbugs (version
2.0.3) warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2208//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2208//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2208//console
This message is automatically generated.
> Turn off "internationalization warnings" in findbugs exclude file
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1975
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1975
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Affects Versions: 3.5.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1975.patch, ZOOKEEPER-1975.patch.2
>
>
> A more recent version of findbugs (2.0.3) added some checks - one is for
> internationalization issues. We should fix these, but for the time being
> we'll ignore them. (I'll also create a separate jira to address this in
> future)
--
This message was sent by Atlassian JIRA
(v6.2#6252)