[
https://issues.apache.org/jira/browse/ZOOKEEPER-1970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14068445#comment-14068445
]
Rakesh R commented on ZOOKEEPER-1970:
-------------------------------------
[~hdeng] one idea could be raise subtasks for the 'Warning Type' and handle the
cases under this category separately. For the 'Internationalization Warnings'
if the patch becomes too big to review and pushing in, then it would be nice to
group few classes together and put a patch for reviews. What do you say ?
> Fix Findbugs Warnings
> ---------------------
>
> Key: ZOOKEEPER-1970
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1970
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Hongchao Deng
> Assignee: Hongchao Deng
> Fix For: 3.5.0
>
>
> The findbugs complained a lot of warnings after upgrade:
> https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2191//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html#Warnings_I18N
> It would be great to get those warnings settled before 3.5.0 release.
> My proposal is:
> 1. Ignore those "Internationalization Warnings" which is related to encoding.
> And create a new JIRA to fix encoding later.
> 2. fix warnnings of:
> * Multithreaded correctness Warnings
> * Performance Warnings
> * Dodgy code Warnings
--
This message was sent by Atlassian JIRA
(v6.2#6252)
