[
https://issues.apache.org/jira/browse/ZOOKEEPER-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073456#comment-14073456
]
Raul Gutierrez Segales commented on ZOOKEEPER-1988:
---------------------------------------------------
This is slightly outside of the scope of this patch (and a nit) but if you have
the cycles moving all the file path conversions to one util function would
clean up things a bit, see:
{noformat}
$ git grep "osname.toLowerCase().contains"
src/java/test/org/apache/zookeeper/server/InvalidSnapCountTest.java:
if (osname.toLowerCase().contains("windows"))
src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java:
if (osname.toLowerCase().contains("windows"
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java:
if (osname.toLowerCase().contains("window
src/java/test/org/apache/zookeeper/server/util/DynamicConfigBCTest.java:
if (osname.toLowerCase().contains("windows
{noformat}
so having a normalizeFilePath() or such would make it easier to maintain.
Less lines of code is always nice :-)
It's also such a small change that another JIRA is probably overkill.
> new test patch
> --------------
>
> Key: ZOOKEEPER-1988
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1988
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: tests
> Reporter: Raul Gutierrez Segales
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1987-ver4.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
