[jira] [Commented] (ZOOKEEPER-1988) new test patch to verify dynamic reconfig backward compatibility

[Rakesh R (JIRA)]

    [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14074202#comment-14074202
 ] 

Rakesh R commented on ZOOKEEPER-1988:
-------------------------------------

[~shralex] Since its doing the path conversion outside the 
QPC#writeDynamicConfig(), its missed in one more case. Please see the below 
snippet where its forming the dynamic config in backward compatible way. I've 
modified the patch little bit and attached the same. Apart from this I'm OK 
with the patch.

{code}
QPC#writeDynamicConfig()

        if (configBackwardCompatibilityMode) {
            dynamicConfigFilename = configFileStr + ".dynamic";
        }
{code}

> new test patch to verify dynamic reconfig backward compatibility
> ----------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1988
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1988
>             Project: ZooKeeper
>          Issue Type: Sub-task
>          Components: tests
>            Reporter: Raul Gutierrez Segales
>            Assignee: Alexander Shraer
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1987-ver4.patch, ZOOKEEPER-1987-ver5.patch, 
> ZOOKEEPER-1987-ver6.patch, ZOOKEEPER-1987-ver7.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)