[
https://issues.apache.org/jira/browse/ZOOKEEPER-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14078237#comment-14078237
]
Marshall McMullen commented on ZOOKEEPER-1998:
----------------------------------------------
[~rgs] - yep, you're right. I added that code as part of ZOOKEEPER-107 working
with [~shralex]. But if I recall correctly, the original code also
unconditionally called resolve_hosts. Though I'd have to go look at the
original code to confirm that. I'm guessing you've done that already and that
it did not do that?
Do you have thoughts on how we could avoid this? I suppose we could easily just
check if the addrvec is the same and if it is bypass resolving the hosts.
> C library calls getaddrinfo unconditionally from zookeeper_interest
> -------------------------------------------------------------------
>
> Key: ZOOKEEPER-1998
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1998
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.5.0
> Reporter: Raul Gutierrez Segales
> Assignee: Raul Gutierrez Segales
> Priority: Critical
> Fix For: 3.5.0
>
>
> (commented this on ZOOKEEPER-338)
> I've just noticed that we call getaddrinfo from zookeeper_interest... on
> every call. So from zookeeper_interest we always call update_addrs:
> https://github.com/apache/zookeeper/blob/trunk/src/c/src/zookeeper.c#L2082
> which in turns unconditionally calls resolve_hosts:
> https://github.com/apache/zookeeper/blob/trunk/src/c/src/zookeeper.c#L787
> which does the unconditional calls to getaddrinfo:
> https://github.com/apache/zookeeper/blob/trunk/src/c/src/zookeeper.c#L648
> We should fix this since it'll make 3.5.0 slower for people relying on DNS. I
> think this is happened as part of ZOOKEEPER-107 in which the list of servers
> can be updated.
> cc: [~shralex], [~phunt], [~fpj]
--
This message was sent by Atlassian JIRA
(v6.2#6252)
