[
https://issues.apache.org/jira/browse/ZOOKEEPER-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14080861#comment-14080861
]
Rakesh R commented on ZOOKEEPER-1999:
-------------------------------------
Good catch!
Actually this verification point is missing many times. Just tried one sample
script to verify the line endings:
{code}
#!/usr/bin/env bash
if awk '/\r$/{exit 0;} 1{exit 1;}' DynamicConfigBackwardCompatibilityTest.java
then
echo "is DOS"
fi
if [[ "$(head -1 DynamicConfigBackwardCompatibilityTest.java)" == *$'\r' ]];
then echo DOS; fi
{code}
> Converting CRLF to LF in DynamicConfigBackwardCompatibilityTest
> ---------------------------------------------------------------
>
> Key: ZOOKEEPER-1999
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1999
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.5.0
> Reporter: Hongchao Deng
> Assignee: Hongchao Deng
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1999.patch
>
>
> The gitattributes set java files line ending be LF.
> The DynamicConfigBackwardCompatibilityTest.java uses CRLF and should be
> converted to LF.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
