[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14081137#comment-14081137
 ] 

Hongchao Deng commented on ZOOKEEPER-1992:
------------------------------------------

[~shralex]
I finished it and uploaded the new patch.

As usual, review place:
https://github.com/fengjingchao/zookeeper/commit/621f9f641945f4b9d7050c41bf9a2069baf1d582?w=1

I also added the check on editing static file.

{quote}
on accept() a server socket returns a new socket which the newly connected 
client and the server use. So as I understand it, closing the server socket 
doesn't kill the existing connections - they are using different sockets.
{quote}
So I think on reconfig a client will be "redirected" to a new server port. This 
is not shown in cli tool, I mean.

> backward compatibility of zoo.cfg
> ---------------------------------
>
>                 Key: ZOOKEEPER-1992
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1992
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.5.0
>            Reporter: Hongchao Deng
>            Assignee: Hongchao Deng
>            Priority: Blocker
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1992-addTest.patch, 
> ZOOKEEPER-1992-gitaddp.patch, ZOOKEEPER-1992-without-spaces.patch, 
> ZOOKEEPER-1992-withspaces.patch, draft-2.patch, draft-3.patch, draft-4.patch, 
> draft.patch
>
>
> This issue supersedes our discussion in ZOOKEEPER-1989.
> To summarize, ZK users can seamlessly upgrade 3.4 to 3.5. But two things will 
> happen:
> 1. the server list will be separated out as a dynamic file (the original 
> should be backup automatically).
> 2. Client port is mandatory on reconfig. So when reconfig the server itself 
> (its id), the client port in config file will be removed and replaced by the 
> one in reconfig (written in dynamic file).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to