[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14099451#comment-14099451
 ] 

Alexander Shraer commented on ZOOKEEPER-2006:
---------------------------------------------

Hi Hongchao, thanks for the patch!
Its probably better to take this logic out of CheckValidity. The name of the 
function implies that its only checking stuff but not modifying state. How 
about putting it in a separate function and invoking it after CheckValidity ?

> Standalone mode won't take client port from dynamic config file
> ---------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2006
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2006
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.5.0
>            Reporter: Hongchao Deng
>            Assignee: Hongchao Deng
>         Attachments: ZOOKEEPER-2006.patch, draft
>
>
> Currently, when a server only specify client port only in dynamic file, on 
> standalone mode it will be ignored and no client port will be setup.
> It confuses the use of dynamic file and we should come up with something to 
> handle this. One solution would be dynamic file doesn't allow standalone mode.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to