[
https://issues.apache.org/jira/browse/ZOOKEEPER-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14100352#comment-14100352
]
Hadoop QA commented on ZOOKEEPER-2006:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12662420/ZOOKEEPER-2006-v5.patch
against trunk revision 1617921.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2288//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2288//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2288//console
This message is automatically generated.
> Standalone mode won't take client port from dynamic config file
> ---------------------------------------------------------------
>
> Key: ZOOKEEPER-2006
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2006
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.5.0
> Reporter: Hongchao Deng
> Assignee: Hongchao Deng
> Attachments: ZOOKEEPER-2006-v2.patch, ZOOKEEPER-2006-v3.patch,
> ZOOKEEPER-2006-v4.patch, ZOOKEEPER-2006-v5.patch, ZOOKEEPER-2006.patch, draft
>
>
> When clientPort is specified in the new format, using
> "server.x=host:port1:port2;clientPort" in either static or dynamic file and
> without a "clientPort = xxxx" statement, a standalone mode server doesn't set
> up client port.
> A second problem is that zkServer.sh looks for the client port in both static
> and dynamic files, but when looking in the static files it only looks for the
> "clientPort" statement, so if its specified in the new format the port will
> be missed and commands such as "zkServer.sh status" will not work. This is a
> problem for standalone mode, but also in distributed mode when the server is
> still LOOKING (once a leader is established and the server is
> LEADING/FOLLOWING/OBSERVING, a dynamic file is created and the client port
> will be found by the script).
> Review Board:
> https://reviews.apache.org/r/24786/
--
This message was sent by Atlassian JIRA
(v6.2#6252)
