[
https://issues.apache.org/jira/browse/ZOOKEEPER-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14110236#comment-14110236
]
Raul Gutierrez Segales commented on ZOOKEEPER-2019:
---------------------------------------------------
Failures seem unrelated:
{noformat}
[exec] [junit] 2014-08-26 02:53:32,839 [myid:] - INFO
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@62] - TEST METHOD FAILED
testReadArrayOffsetLength_LengthTooLarge
[exec] [junit] 2014-08-26 02:56:13,636 [myid:] - INFO
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@62] - TEST METHOD FAILED
testTooManySnapshotsNonessential
[exec] [junit] 2014-08-26 02:56:13,641 [myid:] - INFO
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@62] - TEST METHOD FAILED
testTooManySnapshotsEssential
[exec] [junit] 2014-08-26 02:56:13,650 [myid:] - INFO
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@62] - TEST METHOD FAILED
testTryWithResourceThrottle
[exec] [junit] Test org.apache.zookeeper.test.NioNettySuiteHammerTest
FAILED (crashed)
[exec] [junit] 2014-08-26 03:21:37,644 [myid:] - INFO
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@62] - TEST METHOD FAILED
testPortChange
[exec] [junit] 2014-08-26 03:21:37,683 [myid:] - INFO
[main:ZKTestCase$1@70] - FAILED testPortChange
[exec] [junit] Test org.apache.zookeeper.test.ReconfigTest FAILED
[exec] [junit] 2014-08-26 03:24:11,194 [myid:] - INFO
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@62] - TEST METHOD FAILED
testTwoInvalidHostAddresses
[exec] BUILD FAILED
{noformat}
> Unhandled exception when setting invalid limits data in
> /zookeeper/quota/some/path/zookeeper_limits
> ----------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2019
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2019
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Reporter: Raul Gutierrez Segales
> Assignee: Raul Gutierrez Segales
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-2019.patch, ZOOKEEPER-2019.patch
>
>
> If you have quotas properly set for a given path, i.e.:
> {noformat}
> create /zookeeper/quota/test/zookeeper_limits 'count=1,bytes=100'
> create /zookeeper/quota/test/zookeeper_stats 'count=1,bytes=100'
> {noformat}
> and then you update the limits znode with bogus data, i.e.:
> {noformat}
> set /zookeeper/quota/test/zookeeper_limits ''
> {noformat}
> you'll crash the cluster because IllegalArgumentException isn't handled when
> dealing with quotas znodes:
> https://github.com/apache/zookeeper/blob/ZOOKEEPER-823/src/java/main/org/apache/zookeeper/server/DataTree.java#L379
> https://github.com/apache/zookeeper/blob/ZOOKEEPER-823/src/java/main/org/apache/zookeeper/server/DataTree.java#L425
> We should handle IllegalArgumentException. Optionally, we should also throw
> BadArgumentsException from PrepRequestProcessor.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
