> On Sept. 2, 2014, 9:39 p.m., Grant Monroe wrote: > > ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java, > > line 351 > > <https://reviews.apache.org/r/25160/diff/1/?file=671464#file671464line351> > > > > Should this be continue instead of return? If a single session has > > reached MAX_OUTSTANDING_READS_PER_SESSION, do we won't to stop processing > > other sessions?
Yes, good catch, it should be continue instead of return at the other lines in that loop as well. > On Sept. 2, 2014, 9:39 p.m., Grant Monroe wrote: > > ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java, > > line 281 > > <https://reviews.apache.org/r/25160/diff/1/?file=671464#file671464line281> > > > > I think this would be clearer as > > > > if (needCommit(request) || > > pendingRequests.keySet().contains(request.sessionId)) { > > addToPending(request); > > } else { > > getSessionsRequests(request).addLast(request); > > } Agree. - Kfir ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/#review52075 ----------------------------------------------------------- On Aug. 28, 2014, 6:27 p.m., Kfir Lev-Ari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25160/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2014, 6:27 p.m.) > > > Review request for zookeeper, Raul Gutierrez Segales and Alexander Shraer. > > > Repository: zookeeper > > > Description > ------- > > Please see https://issues.apache.org/jira/browse/ZOOKEEPER-2024 > > > Diffs > ----- > > ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java > 1619360 > > ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java > 1619360 > ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java > 1619360 > > Diff: https://reviews.apache.org/r/25160/diff/ > > > Testing > ------- > > The attached unit tests, as well as the system test found in > https://issues.apache.org/jira/browse/ZOOKEEPER-2023. > > > Thanks, > > Kfir Lev-Ari > >
