[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14187395#comment-14187395
 ] 

Ian Dimayuga commented on ZOOKEEPER-2063:
-----------------------------------------

It seems NettyServerCnxnTest also assumes one single pipeline, and manually 
injects a channel handler to that pipeline:

{code:java}
        LOG.info("Adding custom channel handler for simulation");
        nettyServerFactory.bootstrap.getPipeline().remove("servercnxnfactory");
        nettyServerFactory.bootstrap.getPipeline().addLast("servercnxnfactory", 
channelHandler);
{code}

It seems this would not be compatible with a change that uses a 
ChannelPipelineFactory instead of modifying ServerBootstrap's pipeline 
directly. The unit test will probably need to implement its own 
ChannelPipelineFactory to add this custom handler.

> Netty+SSL support for client-server communication
> -------------------------------------------------
>
>                 Key: ZOOKEEPER-2063
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2063
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Hongchao Deng
>            Assignee: Hongchao Deng
>
> ZooKeeper currently have netty option on server side. We want to support 
> netty on client side too. After that, we could add ssl support based on netty 
> channel.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to