[
https://issues.apache.org/jira/browse/ZOOKEEPER-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14196476#comment-14196476
]
Hadoop QA commented on ZOOKEEPER-2073:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12679251/ZOOKEEPER-2073.patch
against trunk revision 1634776.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2422//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2422//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2422//console
This message is automatically generated.
> Memory leak on zookeeper_close
> ------------------------------
>
> Key: ZOOKEEPER-2073
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2073
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.6.0
> Reporter: Dave Gosselin
> Priority: Critical
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER-2073.patch
>
>
> When running valgrind against a zookeeper client using the C API, I noticed
> an occasional memory leak on zookeeper_close. I traced the issue to a
> regression added by fix ZOOKEEPER-804. The attached patch fixes the
> regression and the associated memory leak.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)