> On Nov. 24, 2014, 6:53 p.m., Raul Gutierrez Segales wrote: > > src/java/main/org/apache/zookeeper/ClientCnxnSocket.java, line 179 > > <https://reviews.apache.org/r/27244/diff/20/?file=758279#file758279line179> > > > > By extraplation I meant that this: > > > > ``` > > LOG.debug("deferring non-priming packet {} until SASL authentation > > completes.", p); > > ``` > > > > reads nicer than using +. > > > > I also think you can drop the if (LOG.isDebugEnabled()) fencing > > entirely, since it only makes sense when it's very expensive to generate > > the debug message (which, I think, isn't the case here).
This was part of the legacy code that I moved from NIO. Anyway, time to fix and make it better :) - Hongchao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27244/#review62842 ----------------------------------------------------------- On Nov. 22, 2014, 5:46 p.m., Hongchao Deng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27244/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2014, 5:46 p.m.) > > > Review request for zookeeper. > > > Repository: zookeeper-git > > > Description > ------- > > ZOOKEEPER-2069 > > > Diffs > ----- > > src/java/main/org/apache/zookeeper/ClientCnxn.java b4ece07 > src/java/main/org/apache/zookeeper/ClientCnxnSocket.java 5ca0ba7 > src/java/main/org/apache/zookeeper/ClientCnxnSocketNIO.java adb27ee > src/java/main/org/apache/zookeeper/ClientCnxnSocketNetty.java PRE-CREATION > src/java/main/org/apache/zookeeper/ZooKeeper.java dd13cc9 > src/java/test/org/apache/zookeeper/test/NettyNettySuiteBase.java > PRE-CREATION > src/java/test/org/apache/zookeeper/test/NettyNettySuiteHammerTest.java > PRE-CREATION > src/java/test/org/apache/zookeeper/test/NettyNettySuiteTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/27244/diff/ > > > Testing > ------- > > > Thanks, > > Hongchao Deng > >
