[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230618#comment-14230618
 ] 

Hongchao Deng commented on ZOOKEEPER-1559:
------------------------------------------

Hi [~fpj].

As far as I understand the problem, it's quite tricky:
1. leader loads all txns in loadDataBase() including uncommitted ones.
2. leader sends in-mem DataTree snapshot in SNAP message.
3. learner takes snapshot on receiving NEWLEADER, which doesn't have quorum 
support yet.

It would be easy to fix (3) on my side. But fixing (1) and (2) are complex and 
require huge changes. I am hoping that you can give some *advice* to move 
forward and fix this issue. Thanks!

> Learner should not snapshot uncommitted state
> ---------------------------------------------
>
>                 Key: ZOOKEEPER-1559
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1559
>             Project: ZooKeeper
>          Issue Type: Sub-task
>          Components: quorum
>            Reporter: Flavio Junqueira
>            Assignee: Hongchao Deng
>
> The code in Learner.java is a bit entangled for backward compatibility 
> reasons. We need to make sure that we can remove the calls to take a snapshot 
> without breaking it. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to