[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14235056#comment-14235056
 ] 

Hadoop QA commented on ZOOKEEPER-2093:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12684450/export-cumulative-latency.patch
  against trunk revision 1642444.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2447//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2447//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2447//console

This message is automatically generated.

> Expose cumulative latency and request count
> -------------------------------------------
>
>                 Key: ZOOKEEPER-2093
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2093
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: jmx, server
>            Reporter: Brian Brazil
>            Priority: Minor
>              Labels: patch
>         Attachments: export-cumulative-latency.patch
>
>
> Currently Zookeeper exposes min, max and average since server start request 
> latency.
> It'd also be useful to be able to calculate latency over a given time period. 
> This patch exposes the total latency, and count of number of request. By 
> tracking how these values increase over time, your monitoring system can 
> calculate the average latency over a given period of time.
> This only provides milliseconds, as that's what's currently there.
> I'm seeing a test failure on ClientPortBindTest.testBindByAddress, this 
> appears to be due to my IPv6 setup.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to