[
https://issues.apache.org/jira/browse/ZOOKEEPER-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14249063#comment-14249063
]
Hadoop QA commented on ZOOKEEPER-1963:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12687586/ZOOKEEPER-1963-v2.patch
against trunk revision 1642444.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2463//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2463//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2463//console
This message is automatically generated.
> Make JDK 7 the minimum requirement for Zookeeper
> ------------------------------------------------
>
> Key: ZOOKEEPER-1963
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1963
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.5.0
> Reporter: Edward Carter
> Assignee: Hongchao Deng
> Fix For: 3.5.1
>
> Attachments: ZOOKEEPER-1963-v2.patch, ZOOKEEPER-1963.patch
>
>
> JDK 6 stopped receiving public updates in early 2013:
> http://www.oracle.com/technetwork/java/eol-135779.html
> I propose making JDK 7 the minimum for Zookeeper going forward. One patch
> that I've personally submitted already would have been a good fit for Java
> 7's try-with-resources statement, and another pending patch fails to build on
> versions of Java prior to 7 because a unit test in it uses
> InetAddress.getLoopbackAddress(), which would be awkward to replace. I'm
> sure there are many other examples.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
