[
https://issues.apache.org/jira/browse/ZOOKEEPER-2095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14253408#comment-14253408
]
Guillaume ALAUX commented on ZOOKEEPER-2095:
--------------------------------------------
{quote}-1 tests included. The patch doesn't appear to include any new or
modified tests.
Please justify why no new tests are needed for this patch.{quote}
The patch does not applies to *code* but instead add external startup scripts
and config.
{quote}Also please list what manual steps were performed to verify this
patch.{quote}
This systemd conf is already used in a full Arch Linux (non-official) package
[available here|https://aur.archlinux.org/packages/zookeeper/]. Two other
non-official packages rely on these files as can be seen
[here|https://aur.archlinux.org/packages/kafka/] and
[here|https://aur.archlinux.org/packages/storm/].
{quote}-1 release audit. The applied patch generated 4 release audit warnings
(more than the trunk's current 0 warnings).{quote}
Newly attached patch fixes this.
{quote}-1 core tests. The patch failed core unit tests.{quote}
Tests seem to fail with or without this patch.
> Add Systemd startup/conf files
> ------------------------------
>
> Key: ZOOKEEPER-2095
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2095
> Project: ZooKeeper
> Issue Type: Improvement
> Components: contrib
> Reporter: Guillaume ALAUX
> Priority: Minor
> Attachments: ZOOKEEPER-2095.patch
>
>
> As adoption of systemd by distributions grows, it would be nice to have
> systemd configuration and startup files for Zookeeper in the upstream tree. I
> would thus like to contribute the following patch which brings the followings
> systemd files:
> - {{sysusers.d_zookeeper.conf}}: creates {{zookeeper}} Linux system user to
> run Zookeeper
> - {{tmpfiles.d_zookeeper.conf}}: creates temporary {{/var/log/zookeeper}} and
> {{/var/lib/zookeeper} directories
> - {{zookeeper.service}}: regular systemd startup _script_
> - {{[email protected]}}: systemd startup _script_ for specific use (for
> instance when Zookeeper is invoked to support some other piece of software –
> [example for
> Kafka|http://pkgbuild.com/git/aur-mirror.git/tree/kafka/systemd_kafka.service#n3],
> [example for
> Storm|http://pkgbuild.com/git/aur-mirror.git/tree/storm/systemd_storm-nimbus.service#n3])
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
