[
https://issues.apache.org/jira/browse/ZOOKEEPER-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14299760#comment-14299760
]
Hudson commented on ZOOKEEPER-2111:
-----------------------------------
FAILURE: Integrated in ZooKeeper-trunk #2581 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2581/])
ZOOKEEPER-2111 Not isAlive states should be synchronized in ClientCnxn
(Hongchao via rakeshr) (rakeshr:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1656167)
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/ClientCnxn.java
> Not isAlive states should be synchronized in ClientCnxn
> -------------------------------------------------------
>
> Key: ZOOKEEPER-2111
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2111
> Project: ZooKeeper
> Issue Type: Bug
> Components: java client
> Reporter: Hongchao Deng
> Assignee: Hongchao Deng
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2111.patch, ZOOKEEPER-2111.patch,
> ZOOKEEPER-2111.patch, ZOOKEEPER-2111.patch
>
>
> In ClientCnxn.queuePacket, it checks variables of state and closing and then
> make decisions. There is toctou race in queuePacket():
> {code}
> if (!state.isAlive() || closing) {
> conLossPacket(packet);
> } else {
> ...
> }
> {code}
> A possible race:
> in SendThread.run():
> {code}
> while (state.isAlive()) {
> ...
> }
> cleanup();
> {code}
> When it checks in queuePacket(), state is still alive. Then state isn't
> alive, SendThread.run() cleans up outgoingQueue. Then queuePacket adds packet
> to outgoingQueue. The packet should be waken up with exception. But it won't
> at this case.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
