[
https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14301434#comment-14301434
]
Hongchao Deng commented on ZOOKEEPER-2094:
------------------------------------------
Regarding the patch, I have a few questions:
h3. 4lws
Is the new function
{code}
String send4LetterWord(String host, int port, String cmd, boolean secure)
{code}
used in testing only? I don't think this is necessary. We might deprecate 4lws
in the future and use Jetty server to replace that. For the legacy test, we
could have two port, one for normal and one for SSL, and use the legacy code to
connect to the normal one.
h3. clientPort
>From what I review, the patch is enabling another SSL port. In 3.5+, client
>port is included dynamic reconfig. It feels awkward to me that you have a
>normal client port in dynamic config and another SSL port in static config.
>Let's have more discussion here.
h3. ZooKeeperServer
I think the patch starts two CNXNs and they share on ZKServer object. Is there
any concurrency concern?
I would like to have more discussion and sort things out.
> SSL support for NettyServerCnxnFactory
> --------------------------------------
>
> Key: ZOOKEEPER-2094
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Affects Versions: 3.4.6, 3.5.0
> Reporter: Ian Dimayuga
> Assignee: Ian Dimayuga
> Fix For: 3.5.1
>
> Attachments: ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch,
> ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch,
> ZOOKEEPER-2094.patch
>
>
> Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider
> to perform authentication.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
