[
https://issues.apache.org/jira/browse/ZOOKEEPER-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14308985#comment-14308985
]
Hudson commented on ZOOKEEPER-1366:
-----------------------------------
FAILURE: Integrated in ZooKeeper-trunk #2587 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2587/])
ZOOKEEPER-1366 Zookeeper should be tolerant of clock adjustments (Hongchao Deng
via michim) (michim:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1657745)
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/ClientCnxn.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/ClientCnxnSocket.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/Login.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/Shell.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/ZKUtil.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/common/Time.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ConnectionBean.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ExpiryQueue.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/RateLogger.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/Request.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ServerStats.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/WorkerService.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ZKDatabase.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/AuthFastLeaderElection.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/Follower.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/Leader.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/LearnerSnapshotThrottler.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
*
/zookeeper/trunk/src/java/systest/org/apache/zookeeper/test/system/GenerateLoad.java
*
/zookeeper/trunk/src/java/systest/org/apache/zookeeper/test/system/InstanceManager.java
*
/zookeeper/trunk/src/java/systest/org/apache/zookeeper/test/system/SimpleSysTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/common/TimeTest.java
*
/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ClientBase.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ClientHammerTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/CnxManagerTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ReadOnlyModeTest.java
*
/zookeeper/trunk/src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/TestHammer.java
*
/zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ZooKeeperTestClient.java
> Zookeeper should be tolerant of clock adjustments
> -------------------------------------------------
>
> Key: ZOOKEEPER-1366
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1366
> Project: ZooKeeper
> Issue Type: Bug
> Reporter: Ted Dunning
> Assignee: Hongchao Deng
> Priority: Critical
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-1366-3.3.3.patch, ZOOKEEPER-1366.patch,
> ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch,
> ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch,
> ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch,
> ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch,
> ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch,
> zookeeper-3.4.5-ZK1366-SC01.patch
>
>
> If you want to wreak havoc on a ZK based system just do [date -s "+1hour"]
> and watch the mayhem as all sessions expire at once.
> This shouldn't happen. Zookeeper could easily know handle elapsed times as
> elapsed times rather than as differences between absolute times. The
> absolute times are subject to adjustment when the clock is set while a timer
> is not subject to this problem. In Java, System.currentTimeMillis() gives
> you absolute time while System.nanoTime() gives you time based on a timer
> from an arbitrary epoch.
> I have done this and have been running tests now for some tens of minutes
> with no failures. I will set up a test machine to redo the build again on
> Ubuntu and post a patch here for discussion.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
