[
https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309820#comment-14309820
]
Hongchao Deng commented on ZOOKEEPER-2094:
------------------------------------------
Hi Ian.
I do the following changes:
1. docs in cli tool
2. input stream close in X509Auth
3. rename: getSecureClientCnxns -> isCnxnsSecure
4. throw exception when ssl on server isn’t set up.
5. There is ordering requirement between cnxnFactory and secureCnxnFactory. It
shouldn’t rely on “zks.running”
6. synchronized on “initialized in AuthenticationProvider class
7. unnecessary imports & Formatting
Please take a look at the RB (there is a function to show difference to
previous changes).
I did a basic throw exception in server side handling null ssl context. I think
it would cause NPE in client so I haven't done anything about it.
Let's discuss more on handling user input. Other than that, everything looks
good to me. I run multiple jenkins test and it goes well so far.
> SSL feature on Netty
> --------------------
>
> Key: ZOOKEEPER-2094
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Affects Versions: 3.4.6, 3.5.0
> Reporter: Ian Dimayuga
> Assignee: Ian Dimayuga
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch,
> ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch,
> ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, test.cert,
> testKeyStore.jks, testTrustStore.jks, testUntrustedKeyStore.jks
>
>
> Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider
> to perform authentication.
> Review board: https://reviews.apache.org/r/30576/diff/#
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
