[
https://issues.apache.org/jira/browse/ZOOKEEPER-2124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14330450#comment-14330450
]
Hadoop QA commented on ZOOKEEPER-2124:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12700058/ZOOKEEPER-2124-trunk.patch
against trunk revision 1658888.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2524//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2524//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2524//console
This message is automatically generated.
> Allow Zookeeper version string to have underscore '_'
> -----------------------------------------------------
>
> Key: ZOOKEEPER-2124
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2124
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.4.6
> Reporter: Jerry He
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2124-3.5.patch, ZOOKEEPER-2124-trunk.patch
>
>
> Using Bigtop or other RPM build for Zookeeper, there is a problem with using
> the hyphen '-' character in the version string:
> {noformat}
> [bigdata@bdvs1166 bigtop]$ gradle zookeeper-rpm
> :buildSrc:compileJava UP-TO-DATE
> :buildSrc:compileGroovy UP-TO-DATE
> :buildSrc:processResources UP-TO-DATE
> :buildSrc:classes UP-TO-DATE
> :buildSrc:jar UP-TO-DATE
> :buildSrc:assemble UP-TO-DATE
> :buildSrc:compileTestJava UP-TO-DATE
> :buildSrc:compileTestGroovy UP-TO-DATE
> :buildSrc:processTestResources UP-TO-DATE
> :buildSrc:testClasses UP-TO-DATE
> :buildSrc:test UP-TO-DATE
> :buildSrc:check UP-TO-DATE
> :buildSrc:build UP-TO-DATE
> :zookeeper_vardefines
> :zookeeper-download
> :zookeeper-tar
> Copy /home/bigdata/bigtop/dl/zookeeper-3.4.6-IBM-1.tar.gz to
> /home/bigdata/bigtop/build/zookeeper/tar/zookeeper-3.4.6-IBM-1.tar.gz
> :zookeeper-srpm
> error: line 64: Illegal char '-' in: Version: 3.4.6-IBM-1
> :zookeeper-srpm FAILED
> FAILURE: Build failed with an exception.
> * Where:
> Script '/home/bigdata/bigtop/packages.gradle' line: 462
> * What went wrong:
> Execution failed for task ':zookeeper-srpm'.
> > Process 'command 'rpmbuild'' finished with non-zero exit value 1
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or
> --debug option to get more log output.
> BUILD FAILED
> {noformat}
> Also, according to the
> [rpm-maven-plugin|http://mojo.codehaus.org/rpm-maven-plugin/ident-params.html]
> documentation:
> {noformat}
> version
> The version number to use for the RPM package. By default, this is the
> project version. This value cannot contain a dash (-) due to contraints in
> the RPM file naming convention. Any specified value will be truncated at the
> first dash
> release
> The release number of the RPM.
> Beginning with release 2.0-beta-2, this is an optional parameter. By default,
> the release will be generated from the modifier portion of the project
> version using the following rules:
> If no modifier exists, the release will be 1.
> If the modifier ends with SNAPSHOT, the timestamp (in UTC) of the build will
> be appended to end.
> All instances of '-' in the modifier will be replaced with '_'.
> If a modifier exists and does not end with SNAPSHOT, "_1" will be appended to
> end.
> {noformat}
> We should allow underscore '_' as part of the version string. e.g.
> 3.4.6_abc_1
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
