> On March 2, 2015, 5:30 p.m., Hongchao Deng wrote:
> > ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java, line 690
> > <https://reviews.apache.org/r/20071/diff/6-7/?file=868720#file868720line690>
> >
> > state != State.Running.
Or we can just leave "if (firstProcessor == null) {" unchanged. This is the
original behavior.
- Hongchao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20071/#review74757
-----------------------------------------------------------
On March 2, 2015, 5:26 p.m., Rakesh R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20071/
> -----------------------------------------------------------
>
> (Updated March 2, 2015, 5:26 p.m.)
>
>
> Review request for zookeeper, michim, Raul Gutierrez Segales, and Camille
> Fournier.
>
>
> Bugs: ZOOKEEPER-1907
> https://issues.apache.org/jira/browse/ZOOKEEPER-1907
>
>
> Repository: zookeeper
>
>
> Description
> -------
>
> Improve the thread handling mechanism by detecting if any of the critical
> thread dies.
> Here the idea is to periodically checking the status of all the critical
> threads in ZK server using DeathWatcherThread.
>
>
> Diffs
> -----
>
> ./src/java/main/org/apache/zookeeper/server/ExitCode.java PRE-CREATION
> ./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java
> 1661461
> ./src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 1661461
> ./src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java
> 1661461
> ./src/java/main/org/apache/zookeeper/server/ZooKeeperCriticalThread.java
> 1661461
> ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 1661461
> ./src/java/main/org/apache/zookeeper/server/ZooKeeperServerListener.java
> PRE-CREATION
> ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java
> 1661461
>
> ./src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java
> 1661461
>
> ./src/java/main/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java
> 1661461
>
> ./src/java/main/org/apache/zookeeper/server/quorum/LeaderSessionTracker.java
> 1661461
>
> ./src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java
> 1661461
>
> ./src/java/main/org/apache/zookeeper/server/quorum/LearnerSessionTracker.java
> 1661461
>
> ./src/java/main/org/apache/zookeeper/server/quorum/LearnerZooKeeperServer.java
> 1661461
> ./src/java/main/org/apache/zookeeper/server/quorum/LocalSessionTracker.java
> 1661461
>
> ./src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java
> 1661461
>
> ./src/java/main/org/apache/zookeeper/server/quorum/ObserverZooKeeperServer.java
> 1661461
>
> ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java
> 1661461
>
> ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyZooKeeperServer.java
> 1661461
>
> ./src/java/main/org/apache/zookeeper/server/quorum/UpgradeableSessionTracker.java
> 1661461
> ./src/java/test/org/apache/zookeeper/server/ZooKeeperThreadTest.java
> 1661461
>
> ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java
> 1661461
> ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java
> 1661461
> ./src/java/test/org/apache/zookeeper/test/ClientBase.java 1661461
> ./src/java/test/org/apache/zookeeper/test/SessionTrackerCheckTest.java
> 1661461
>
> Diff: https://reviews.apache.org/r/20071/diff/
>
>
> Testing
> -------
>
> yet to be inlcuded
>
>
> Thanks,
>
> Rakesh R
>
>
