[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14352271#comment-14352271
 ] 

Hadoop QA commented on ZOOKEEPER-2000:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12659564/ZOOKEEPER-2000.patch
  against trunk revision 1663127.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 7 new or modified tests.

    -1 patch.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2549//console

This message is automatically generated.

> Fix ReconfigTest.testPortChange
> -------------------------------
>
>                 Key: ZOOKEEPER-2000
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2000
>             Project: ZooKeeper
>          Issue Type: Sub-task
>          Components: tests
>    Affects Versions: 3.5.0
>            Reporter: Alexander Shraer
>            Assignee: Alexander Shraer
>            Priority: Minor
>             Fix For: 3.5.1, 3.6.0
>
>         Attachments: ZOOKEEPER-2000.patch, ZOOKEEPER-2000.patch
>
>
>           testPortChange changes all ports and role of the server and thus 
> causes existing clients to disconnect, while this wouldn't happen if only the 
> client port changes. Need to fix it to only change client port and not all 
> the other parameters and make sure that the clients don't disconnect, while 
> new clients shouldn't be able to connect to the old port.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to