[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14376436#comment-14376436
 ] 

Raul Gutierrez Segales commented on ZOOKEEPER-2146:
---------------------------------------------------

Ah, never mind - you already fixed readBuffer as well. I guess startVector has 
the same problem too and could benefit from checkLen:

{noformat}
    public Index startVector(String tag) throws IOException {
        int len = readInt(tag);
        if (len == -1) {
            return null;
        }
{noformat}

But we can surely do it in another patch. Thanks [~hdeng].

> BinaryInputArchive readString should check length before allocating memory
> --------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2146
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2146
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Hongchao Deng
>            Assignee: Hongchao Deng
>         Attachments: ZOOKEEPER-2146.patch, ZOOKEEPER-2146.patch
>
>
> I recently observed a problem caused by malformed packets. ZK server crashed 
> because of OutOfMemoryError.
> The reason is BinaryInputArchive didn't check the length before allocating 
> memory in readString():
> {code}
>   public String readString(String tag) throws IOException {
>       int len = in.readInt();
>       if (len == -1) return null;
>       byte b[] = new byte[len];
>         ...
> {code}
> I suggest to add the same check as in readBuffer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to