[
https://issues.apache.org/jira/browse/ZOOKEEPER-2062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth updated ZOOKEEPER-2062:
-------------------------------------
Attachment: ZOOKEEPER-2062.003.patch
I'm attaching patch v003. This brings the whole test suite run down to 1
minute 20 seconds on my machine.
This applies the suggestions from the last comment from Rakesh. As mentioned
in my last comment though, I found that {{DataTree#getWatchesByPath}} returned
only data watches. Instead of relying on that, I've added assertions on
whether or not the server-side session is registered as a watcher. Let me know
if this is sufficient.
{{testRemoveSingleWatcher}} and {{testMultipleDataWatchers}} are still a tad
slow. However, I didn't want to change these, because it seems these are
specifically intended to check session close semantics. Once the session is
closed, trying to do these new assertions wouldn't be valid, so I left these
tests waiting on the latches for timeouts.
I also didn't change the {{*NoConnection}} tests. It seems the only option
here would be to downtune client timeout settings, which could get finicky.
I verified again that introducing bugs in {{ZKDatabase}} causes test failures,
so the tests are still capable of catching regressions.
Rakesh and Camille, what do you think of this version? Thanks again for your
guidance!
> RemoveWatchesTest takes forever to run
> --------------------------------------
>
> Key: ZOOKEEPER-2062
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2062
> Project: ZooKeeper
> Issue Type: Bug
> Components: tests
> Affects Versions: 3.5.0
> Reporter: Flavio Junqueira
> Assignee: Chris Nauroth
> Attachments: ZOOKEEPER-2062.001.patch, ZOOKEEPER-2062.002.patch,
> ZOOKEEPER-2062.003.patch
>
>
> [junit] Running org.apache.zookeeper.RemoveWatchesTest
> [junit] Tests run: 46, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
> 306.188 sec
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
