----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32979/ -----------------------------------------------------------
(Updated April 29, 2015, 10:19 a.m.) Review request for zookeeper, Eugene Koontz, Patrick Hunt, and Camille Fournier. Changes ------- Addressed review comments Repository: zookeeper-git Description ------- Today SASLAuthenticationProvider is used for all SASL based authentications which creates some "if/else" statements in ZookeeperSaslClient and ZookeeperSaslServer code with just Kerberos and Digest. We want to use yet another different SASL based authentication and adding one more "if/else" with some code specific just to that new way does not make much sense. Proposal is to allow to plug custom SASL Authentication mechanism(s) without further changes in Zookeeper code. Diffs (updated) ----- src/java/main/org/apache/zookeeper/Login.java 44b0bdf src/java/main/org/apache/zookeeper/LoginFactory.java PRE-CREATION src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java 53f33e8 src/java/main/org/apache/zookeeper/server/ServerCnxnFactory.java 1235faa src/java/main/org/apache/zookeeper/server/ZooKeeperSaslServer.java 60711ee src/java/main/org/apache/zookeeper/server/auth/AuthMethod.java PRE-CREATION src/java/main/org/apache/zookeeper/server/auth/AuthRegistry.java PRE-CREATION src/java/main/org/apache/zookeeper/server/auth/DigestAuthMethod.java PRE-CREATION src/java/main/org/apache/zookeeper/server/auth/KerberosAuthMethod.java PRE-CREATION src/java/test/org/apache/zookeeper/test/SaslPluggableAuthTest.java PRE-CREATION src/java/test/org/apache/zookeeper/test/auth/util/GenericLoginModule.java PRE-CREATION src/java/test/org/apache/zookeeper/test/auth/util/SimpleAuthMethod.java PRE-CREATION src/java/test/org/apache/zookeeper/test/auth/util/SimpleSaslClient.java PRE-CREATION src/java/test/org/apache/zookeeper/test/auth/util/SimpleSaslProvider.java PRE-CREATION src/java/test/org/apache/zookeeper/test/auth/util/SimpleSaslServer.java PRE-CREATION Diff: https://reviews.apache.org/r/32979/diff/ Testing ------- UnitTests passed, New Unit Tests added tested Digest and Kerberos(with real KDC) Thanks, Yuliya Feldman
