[
https://issues.apache.org/jira/browse/ZOOKEEPER-1927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14522886#comment-14522886
]
Hadoop QA commented on ZOOKEEPER-1927:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12729720/ZOOKEEPER-1927.001.patch
against trunk revision 1676359.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2665//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2665//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2665//console
This message is automatically generated.
> zkServer.sh fails to read dataDir (and others) from zoo.cfg on Solaris 10
> (grep issue, manifests as FAILED TO WRITE PID).
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1927
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1927
> Project: ZooKeeper
> Issue Type: Bug
> Components: scripts
> Affects Versions: 3.4.6
> Environment: Solaris 5.10
> Reporter: Ed Schmed
> Assignee: Chris Nauroth
> Fix For: 3.4.7
>
> Attachments: ZOOKEEPER-1927.001.patch
>
>
> Fails to write PID file with a permissions error, because the startup script
> fails to read the dataDir variable from zoo.cfg, and then tries to use the
> drive root ( / ) as the data dir.
> Tracked the problem down to line 84 of zkServer.sh:
> ZOO_DATADIR="$(grep "^[[:space:]]*dataDir" "$ZOOCFG" | sed -e 's/.*=//')"
> If i run just that line and point it right at the config file, ZOO_DATADIR is
> empty.
> If I remove [[:space:]]* from the grep:
> ZOO_DATADIR="$(grep "^dataDir" "$ZOOCFG" | sed -e 's/.*=//')"
> Then it works fine. (If I also make the same change on line 164 and 169)
> My regex skills are pretty bad, so I'm afraid to comment on why [[space]]*
> needs to be in there?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
