[
https://issues.apache.org/jira/browse/ZOOKEEPER-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14523845#comment-14523845
]
Hadoop QA commented on ZOOKEEPER-1077:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12729828/ZOOKEEPER-1077-branch-3.4.002.patch
against trunk revision 1676359.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 15 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2668//console
This message is automatically generated.
> C client lib doesn't build on Solaris
> -------------------------------------
>
> Key: ZOOKEEPER-1077
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1077
> Project: ZooKeeper
> Issue Type: Bug
> Components: build, c client
> Affects Versions: 3.3.4
> Environment: uname -a: SunOS [redacted] 5.10 Generic_142910-17 i86pc
> i386 i86pc
> GNU toolchain (gcc 3.4.3, GNU Make etc.)
> Reporter: Tadeusz Andrzej Kadłubowski
> Assignee: Chris Nauroth
> Priority: Critical
> Fix For: 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-1077-branch-3.4.002.patch,
> ZOOKEEPER-1077.001.patch, ZOOKEEPER-1077.002.patch, zookeeper.patch
>
>
> Hello,
> Some minor trouble with building ZooKeeper C client library on
> Sun^H^H^HOracle Solaris 5.10.
> 1. You need to link against "-lnsl -lsocket"
> 2. ctime_r needs a buffer size. The signature is: "char *ctime_r(const time_t
> *clock, char *buf, int buflen)"
> 3. In zk_log.c you need to manually cast pid_t to int (-Werror can be
> cumbersome ;) )
> 4. getpwuid_r()returns pointer to struct passwd, which works as the last
> parameter on Linux.
> Solaris signature: struct passwd *getpwuid_r(uid_t uid, struct passwd
> *pwd, char *buffer, int buflen);
> Linux signature: int getpwuid_r(uid_t uid, struct passwd *pwd, char *buf,
> size_t buflen, struct passwd **result);
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
