----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34023/#review83176 -----------------------------------------------------------
http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java <https://reviews.apache.org/r/34023/#comment134061> do we need to change the protocol version from 0xffff0000 to -65536? http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java <https://reviews.apache.org/r/34023/#comment134062> - what happens when the previous version sends 0xffff0000? - we don't need to handle messages that don't contain protocol version any more? http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java <https://reviews.apache.org/r/34023/#comment134063> why did this check get removed? - michim On May 9, 2015, 9:19 p.m., michim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34023/ > ----------------------------------------------------------- > > (Updated May 9, 2015, 9:19 p.m.) > > > Review request for zookeeper. > > > Repository: zookeeper > > > Description > ------- > > ZOOKEEPER-2186 QuorumCnxManager#receiveConnection may crash with random input > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java > 1678536 > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/test/CnxManagerTest.java > 1678536 > > Diff: https://reviews.apache.org/r/34023/diff/ > > > Testing > ------- > > > Thanks, > > michim > >
