[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566511#comment-14566511
 ] 

Flavio Junqueira commented on ZOOKEEPER-2197:
---------------------------------------------

Hmm, I tried what you suggested but ant/javac complains:

{noformat}
compile:
    [javac] Compiling 210 source files to 
/home/fpj/code/zookeeper-3.5.1-alpha/build/classes
    [javac] javac: invalid flag: -Dfile.encoding=utf8
{noformat}

This change worked instead for me:

{noformat}
<target name="compile" depends="ivy-retrieve,clover,build-generated">
        <javac srcdir="${java.src.dir}" destdir="${build.classes}" 
includeantruntime="false"
               target="${javac.target}" source="${javac.source}" debug="on" 
encoding="UTF-8">
            <classpath refid="java.classpath"/>
            <compilerarg value="-Xlint:all"/>
            <compilerarg value="-Xlint:-path"/>
        </javac>
    </target>
{noformat}

In general, is everyone happy that we change the encoding to utf-8? I 
personally don't see a big problem, but perhaps we should send a separate note 
to the dev list to see if anyone has a concern. What do you think? 


> non-ascii character in FinalRequestProcessor.java
> -------------------------------------------------
>
>                 Key: ZOOKEEPER-2197
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2197
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Michi Mutsuzaki
>            Assignee: Michi Mutsuzaki
>            Priority: Minor
>             Fix For: 3.5.1, 3.6.0
>
>         Attachments: ZOOKEEPER-2197.patch, ZOOKEEPER-2197.patch
>
>
> src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java:134: 
> error: unmappable character for encoding ASCII
>     [javac]         // was not being queued ??? ZOOKEEPER-558) properly. This 
> happens, for example,



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to