[
https://issues.apache.org/jira/browse/ZOOKEEPER-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14567484#comment-14567484
]
Raul Gutierrez Segales commented on ZOOKEEPER-2197:
---------------------------------------------------
lgtm, except that i'd leave the utf-8 char in:
{code}
--- src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java
(revision 1682822)
+++ src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java
(working copy)
@@ -131,7 +131,7 @@
// ZOOKEEPER-558:
// In some cases the server does not close the connection (e.g.,
closeconn buffer
- // was not being queued — ZOOKEEPER-558) properly. This happens, for
example,
+ // was not being queued - ZOOKEEPER-558) properly. This happens, for
example,
{code}
That way, we'll actually know this works :-) Other than that, +1. Thanks
[~michim]!
> non-ascii character in FinalRequestProcessor.java
> -------------------------------------------------
>
> Key: ZOOKEEPER-2197
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2197
> Project: ZooKeeper
> Issue Type: Bug
> Reporter: Michi Mutsuzaki
> Assignee: Michi Mutsuzaki
> Priority: Minor
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2197.patch, ZOOKEEPER-2197.patch,
> ZOOKEEPER-2197.patch, ZOOKEEPER-2197.patch
>
>
> src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java:134:
> error: unmappable character for encoding ASCII
> [javac] // was not being queued ??? ZOOKEEPER-558) properly. This
> happens, for example,
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
